Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log file rotation bug #41895

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

nicholasberlin
Copy link
Contributor

@nicholasberlin nicholasberlin commented Dec 4, 2024

Proposed commit message

Fix a bug where log files are rotated on startup when interval is configured 
and rotateonstartup is disabled.

Closes: #41894

Relates: elastic/elastic-agent-libs#259

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

References

@nicholasberlin nicholasberlin added bugfix backport-8.x Automated backport to the 8.x branch with mergify labels Dec 4, 2024
@nicholasberlin nicholasberlin requested a review from a team as a code owner December 4, 2024 19:47
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 4, 2024
@nicholasberlin nicholasberlin added the Team:Security-Linux Platform Linux Platform Team in Security Solution label Dec 4, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 4, 2024
@nicholasberlin nicholasberlin force-pushed the nberlin/log_file_rotation_bug branch from 6cb0330 to a43ae2f Compare December 5, 2024 14:18
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the issue and PR references into the proposed commit msg. Please include this with the commit message when you squash.

@nicholasberlin nicholasberlin merged commit b1cc7c5 into main Dec 6, 2024
142 checks passed
@nicholasberlin nicholasberlin deleted the nberlin/log_file_rotation_bug branch December 6, 2024 14:41
mergify bot pushed a commit that referenced this pull request Dec 6, 2024
Fix a bug where log files are rotated on startup when interval is configured
and rotateonstartup is disabled.

Closes: #41894

Relates: elastic/elastic-agent-libs#259
(cherry picked from commit b1cc7c5)
nicholasberlin added a commit that referenced this pull request Dec 9, 2024
Fix a bug where log files are rotated on startup when interval is configured
and rotateonstartup is disabled.

Closes: #41894

Relates: elastic/elastic-agent-libs#259
(cherry picked from commit b1cc7c5)
nicholasberlin added a commit that referenced this pull request Dec 9, 2024
Fix a bug where log files are rotated on startup when interval is configured
and rotateonstartup is disabled.

Closes: #41894

Relates: elastic/elastic-agent-libs#259
(cherry picked from commit b1cc7c5)

Co-authored-by: Nicholas Berlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify bugfix Team:Security-Linux Platform Linux Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log files are rotated on startup when interval is configured and rotateonstartup is disabled
4 participants